Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Conversation

@hafizrahman
Copy link
Contributor

@hafizrahman hafizrahman commented Dec 13, 2024

Part of woocommerce/woocommerce-android#13115

Working on adding the endpoint for /wc/v3/orders/batch
Documentation in pe5sF9-3kb-p2

This PR adds the following:

  • REST client functionality to do batch orders status update
  • Order store functionality to do batch orders status update
  • Unit tests for the store

Discussion:

  • I'm not adding this case to the Example app: so I can save a bit of time and because I feel the unit tests suffice. But let me know if you prefer to have it added, too.
  • Still undecided whether the function in order store should save the successfully updated Orders to the database. I need to look at the existing behavior in Woo Android, see if it's easier for it to just do a full reload, etc. I'll make another PR later if that's needed.

@irfano irfano self-assigned this Dec 13, 2024
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks for adding extra comments for the functions. I tested WCOrderStore.batchUpdateOrdersStatus() in the Woo app, and it worked as expected. I’ve added a suggestion but am still approving. We can merge once you’ve considered my suggestion.

@hafizrahman hafizrahman merged commit 242d0b6 into trunk Dec 16, 2024
14 checks passed
@hafizrahman hafizrahman deleted the woo/orders-batch-endpoint-p2 branch December 16, 2024 04:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants